r44367 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44366‎ | r44367 | r44368 >
Date:22:24, 9 December 2008
Author:aaron
Status:reverted
Tags:
Comment:
Delay restriction fetching query
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -371,8 +371,9 @@
372372 $this->mTitle->mArticleID = $data->page_id;
373373 $this->mTitle->mTouched = wfTimestamp( TS_MW, $data->page_touched );
374374
375 - # Old-fashioned restrictions.
376 - $this->mTitle->loadRestrictions( $data->page_restrictions );
 375+ # Old-fashioned restrictions
 376+ if( $data->page_restrictions )
 377+ $this->mTitle->loadRestrictions( $data->page_restrictions );
377378
378379 $this->mCounter = $data->page_counter;
379380 $this->mTouched = wfTimestamp( TS_MW, $data->page_touched );
@@ -686,7 +687,7 @@
687688
688689 # Try file cache
689690 if( $oldid === 0 && $this->checkTouched() ) {
690 - $wgOut->setETag($parserCache->getETag($this, $wgUser));
 691+ $wgOut->setETag( $parserCache->getETag($this,$wgUser) );
691692 if( $wgOut->checkLastModified( $this->getTouched() ) ){
692693 wfProfileOut( __METHOD__ );
693694 return;

Follow-up revisions

RevisionCommit summaryAuthorDate
r44368Revert r44367; ends up with an extra fetch :/aaron22:28, 9 December 2008

Status & tagging log