r44195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44194‎ | r44195 | r44196 >
Date:23:04, 3 December 2008
Author:aaron
Status:ok (Comments)
Tags:
Comment:
This seems to be needed to avoid fatals for now
Modified paths:
  • /trunk/extensions/Configure/SpecialExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialExtensions.php
@@ -93,8 +93,9 @@
9494 foreach ( $this->mConfSettings->getAllExtensionsObjects() as $ext ) {
9595 $settings = $ext->getSettings();
9696 foreach ( $settings as $setting => $type ) {
97 - if ( !isset( $GLOBALS[$setting] ) && !isset( $this->conf[$setting] ) && file_exists( $ext->getFile() ) ) {
 97+ if ( !isset($GLOBALS[$setting]) && !isset($this->conf[$setting]) && file_exists($ext->getFile()) ) {
9898 if ( !$globalDone ) {
 99+ extract( $GLOBALS, EXTR_REFS );
99100 global $wgHooks;
100101
101102 $oldHooks = $wgHooks;

Comments

#Comment by Brion VIBBER (talk | contribs)   00:10, 4 December 2008

ewwww extract() is gross

Status & tagging log