r44047 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44046‎ | r44047 | r44048 >
Date:19:42, 29 November 2008
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Renamed PasswordReset class to SpecialResetpass and fixed an entry in SpecialUserlogin.php that was not renamed in r43971.
This also caused a regression with PasswordReset extension (renaming PasswordResetForm to PasswordReset) since this extension also have a PasswordReset class
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialResetpass.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -89,7 +89,7 @@
9090 'CreateAccount' => array( 'SpecialRedirectToSpecial', 'CreateAccount', 'Userlogin', 'signup', array( 'uselang' ) ),
9191 'Preferences' => array( 'SpecialPage', 'Preferences' ),
9292 'Watchlist' => array( 'SpecialPage', 'Watchlist' ),
93 - 'Resetpass' => 'PasswordReset',
 93+ 'Resetpass' => 'SpecialResetpass',
9494
9595
9696 'Recentchanges' => 'SpecialRecentchanges',
Index: trunk/phase3/includes/AutoLoader.php
@@ -469,7 +469,7 @@
470470 'SpecialContributions' => 'includes/specials/SpecialContributions.php',
471471 'NewPagesPager' => 'includes/specials/SpecialNewpages.php',
472472 'PageArchive' => 'includes/specials/SpecialUndelete.php',
473 - 'PasswordReset' => 'includes/specials/SpecialResetpass.php',
 473+ 'SpecialResetpass' => 'includes/specials/SpecialResetpass.php',
474474 'PopularPagesPage' => 'includes/specials/SpecialPopularpages.php',
475475 'PreferencesForm' => 'includes/specials/SpecialPreferences.php',
476476 'RandomPage' => 'includes/specials/SpecialRandompage.php',
Index: trunk/phase3/includes/specials/SpecialResetpass.php
@@ -8,7 +8,7 @@
99 * Let users recover their password.
1010 * @ingroup SpecialPage
1111 */
12 -class PasswordReset extends SpecialPage {
 12+class SpecialResetpass extends SpecialPage {
1313 public function __construct() {
1414 parent::__construct( 'Resetpass' );
1515 }
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -583,7 +583,7 @@
584584 function resetLoginForm( $error ) {
585585 global $wgOut;
586586 $wgOut->addHTML( Xml::element('p', array( 'class' => 'error' ), $error ) );
587 - $reset = new PasswordResetForm( $this->mName, $this->mPassword );
 587+ $reset = new SpecialResetpass();
588588 $reset->execute( null );
589589 }
590590

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43971Cleanup for r43841:...aaron03:37, 26 November 2008

Comments

#Comment by IAlex (talk | contribs)   19:50, 29 November 2008

Should also fix bug 16472.

#Comment by Grondin (talk | contribs)   10:14, 30 November 2008

The bug seems to be fixed. I've no problem for editing, now.

Status & tagging log