r44038 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44037‎ | r44038 | r44039 >
Date:16:52, 29 November 2008
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Remove unused function
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1264,7 +1264,7 @@
12651265 /**
12661266 * @return string Complete article text, or null if error
12671267 */
1268 - function replaceSection( $section, $text, $summary = '', $edittime = NULL ) {
 1268+ public function replaceSection( $section, $text, $summary = '', $edittime = NULL ) {
12691269 wfProfileIn( __METHOD__ );
12701270 if( $section === '' ) {
12711271 // Whole-page edit; let the whole text through
@@ -1347,7 +1347,7 @@
13481348 }
13491349
13501350 $dbw = wfGetDB( DB_MASTER );
1351 - if($watchthis) {
 1351+ if( $watchthis ) {
13521352 if(!$this->mTitle->userIsWatching()) {
13531353 $dbw->begin();
13541354 $this->doWatch();
@@ -2294,18 +2294,7 @@
22952295 LogEventsList::showLogExtract( $wgOut, 'delete', $this->mTitle->getPrefixedText() );
22962296 }
22972297
2298 -
22992298 /**
2300 - * Show relevant lines from the deletion log
2301 - */
2302 - public function showLogExtract( $out ) {
2303 - wfDeprecated( __METHOD__ );
2304 - $out->addHTML( Xml::element( 'h2', null, LogPage::logName( 'delete' ) ) );
2305 - LogEventsList::showLogExtract( $out, 'delete', $this->mTitle->getPrefixedText() );
2306 - }
2307 -
2308 -
2309 - /**
23102299 * Perform a deletion and output success or failure messages
23112300 */
23122301 public function doDelete( $reason, $suppress = false ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   18:55, 10 December 2008

This affects the DeleteQueue extension.

  • ../extensions/DeleteQueue/DeleteQueueInterface.php: $article->showLogExtract( $wgOut );
  • ../extensions/DeleteQueue/DeleteQueueInterface.php: $article->showLogExtract( $wgOut );
  • ../extensions/DeleteQueue/ReviewForm.php: $article->showLogExtract( $wgOut );
#Comment by Brion VIBBER (talk | contribs)   18:56, 10 December 2008

(note the function name is too generic and should die anyway -- it was internal to the deletion form i think, and should probably not have been public.)

Status & tagging log