r44025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44024‎ | r44025 | r44026 >
Date:18:41, 28 November 2008
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 15695) Define 'mw-js-message' to make jsMsg() work in modern skin
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1436,7 +1436,7 @@
14371437 * to ensure that client-side caches don't keep obsolete copies of global
14381438 * styles.
14391439 */
1440 -$wgStyleVersion = '185';
 1440+$wgStyleVersion = '186';
14411441
14421442
14431443 # Server-side caching:
Index: trunk/phase3/skins/Modern.php
@@ -143,6 +143,7 @@
144144 for the margins -->
145145 <div id="mw_contentholder">
146146 <div class='mw-topboxes'>
 147+ <div id="mw-js-message" style="display:none;"></div>
147148 <div class="mw-topbox" id="siteSub"><?php $this->msg('tagline') ?></div>
148149 <?php if($this->data['newtalk'] ) {
149150 ?><div class="usermessage mw-topbox"><?php $this->html('newtalk') ?></div>
Index: trunk/phase3/skins/common/wikibits.js
@@ -851,6 +851,7 @@
852852 }
853853
854854 messageDiv.setAttribute( 'id', 'mw-js-message' );
 855+ messageDiv.style.display = 'block';
855856 if( className ) {
856857 messageDiv.setAttribute( 'class', 'mw-js-message-'+className );
857858 }

Comments

#Comment by Brion VIBBER (talk | contribs)   18:33, 10 December 2008

In the future I'd prefer to unify the id/class structures on all our skins and not have to play such games anymore, but this'll do the job for now...

Status & tagging log