r43463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43462‎ | r43463 | r43464 >
Date:22:48, 13 November 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Show form on token failure
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionCommitter.php
@@ -18,7 +18,8 @@
1919 global $wgRequest, $wgOut, $wgUser;
2020
2121 if( !$wgUser->matchEditToken( $wgRequest->getVal('wpEditToken') ) ) {
22 - $wgOut->addHTML( wfMsg('sessionfailure') );
 22+ $wgOut->addHTML( '<strong>' . wfMsg('sessionfailure') . '</strong>' );
 23+ parent::execute();
2324 return;
2425 }
2526

Comments

#Comment by Brion VIBBER (talk | contribs)   23:25, 13 November 2008

Hmm, form is displaying but it doesn't preserve the status or tag updates from the form submission. These are also being lost on preview...

#Comment by Aaron Schulz (talk | contribs)   23:45, 13 November 2008

Seems to be an old existing bug; things are not taken from GET urls. Fixing...

#Comment by Aaron Schulz (talk | contribs)   00:01, 14 November 2008

Fixed in r43468

Status & tagging log