r43406 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r43405‎ | r43406 | r43407 >
Date:02:13, 12 November 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
'advanced' link consistency
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -732,7 +732,8 @@
733733 if( $active == 'images' ) {
734734 $out .= Xml::element( 'strong', array( 'title'=>$tt ), $m );
735735 } else {
736 - $out .= $this->makeSearchLink( $wgContLang->getFormattedNsText(NS_IMAGE).':'.$bareterm, array() , $m, $tt );
 736+ $imageTextForm = $wgContLang->getFormattedNsText(NS_IMAGE).':'.$bareterm;
 737+ $out .= $this->makeSearchLink( $imageTextForm, array( NS_IMAGE ) , $m, $tt );
737738 }
738739 $out .= $sep;
739740

Follow-up revisions

RevisionCommit summaryAuthorDate
r43499Reverting in-development search changes pending fixing....brion19:11, 14 November 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   19:26, 14 November 2008

Reverted in r43499 pending fixes. Can we do these experimental developments on a branch and avoid merging them to trunk until they're finalized? MediaWiki core trunk is supposed to be ready-to-deploy at all times; experiments should be done in branches, extensions, or disabled-by-default optional features to avoid delaying live code deployments.

Status & tagging log