r43404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r43403‎ | r43404 | r43405 >
Date:01:53, 12 November 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Add valign="top"
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -472,7 +472,7 @@
473473 return "<li>" .
474474 '<table class="searchResultImage">' .
475475 '<tr>' .
476 - '<td width="120" align="center">' .
 476+ '<td width="120" align="center" valign="top">' .
477477 $thumb->toHtml( array( 'desc-link' => true ) ) .
478478 '</td>' .
479479 '<td valign="top">' .

Follow-up revisions

RevisionCommit summaryAuthorDate
r43499Reverting in-development search changes pending fixing....brion19:11, 14 November 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   19:25, 14 November 2008

Reverted in r43499 pending fixes. Can we do these experimental developments on a branch and avoid merging them to trunk until they're finalized? MediaWiki core trunk is supposed to be ready-to-deploy at all times; experiments should be done in branches, extensions, or disabled-by-default optional features to avoid delaying live code deployments.

Status & tagging log