r43385 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43384‎ | r43385 | r43386 >
Date:15:23, 11 November 2008
Author:raymond
Status:old (Comments)
Tags:
Comment:
Cleanup for r43376:
* Use a more precious fieldset legend
* Remove two unused message names from messages.inc
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -766,13 +766,12 @@
767767 'prevn',
768768 'nextn',
769769 'viewprevnext',
 770+ 'searchmenu-legend',
770771 'searchmenu-exists',
771772 'searchmenu-new',
772773 'searchhelp-url',
773774 'searchmenu-prefix',
774775 'searchmenu-help',
775 - 'searchmenu-badtitle',
776 - 'searchmenu',
777776 'searchprofile-articles',
778777 'searchprofile-articles-and-proj',
779778 'searchprofile-project',
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -646,7 +646,7 @@
647647 $out .= wfMsgExt( 'searchmenu-prefix', array('parseinline'), $term );
648648
649649 return Xml::openElement( 'fieldset', array('id' => 'mw-searchoptions','style' => 'margin:0em;') ) .
650 - Xml::element( 'legend', null, wfMsg('searchresults') ) .
 650+ Xml::element( 'legend', null, wfMsg('searchmenu-legend') ) .
651651 $this->formHeader($term) . $out .
652652 Xml::closeElement( 'fieldset' );
653653 }
@@ -792,7 +792,7 @@
793793 $out .= Xml::closeElement( 'form' );
794794 $out .= wfMsgExt( 'searchmenu-prefix', array('parseinline'), $term );
795795 return Xml::openElement( 'fieldset', array('id' => 'mw-searchoptions','style' => 'margin:0em;') ) .
796 - Xml::element( 'legend', null, wfMsg('searchresults') ) .
 796+ Xml::element( 'legend', null, wfMsg('searchmenu-legend') ) .
797797 $this->formHeader($term) . $out .
798798 Xml::closeElement( 'fieldset' );
799799 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1426,6 +1426,7 @@
14271427 'prevn' => 'previous $1',
14281428 'nextn' => 'next $1',
14291429 'viewprevnext' => 'View ($1) ($2) ($3)',
 1430+'searchmenu-legend' => 'Search options',
14301431 'searchmenu-exists' => "'''There is page named \"[[\$1]]\" on this wiki'''",
14311432 'searchmenu-new' => "'''[[\$1|Create]] the page \"[[\$1]]\" on this wiki!'''",
14321433 'searchhelp-url' => 'Project:Searching',

Follow-up revisions

RevisionCommit summaryAuthorDate
r43499Reverting in-development search changes pending fixing....brion19:11, 14 November 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43376* Recommitting Search UI changes from r42352...aaron00:03, 11 November 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   19:25, 14 November 2008

Reverted in r43499 pending fixes. Can we do these experimental developments on a branch and avoid merging them to trunk until they're finalized? MediaWiki core trunk is supposed to be ready-to-deploy at all times; experiments should be done in branches, extensions, or disabled-by-default optional features to avoid delaying live code deployments.

Status & tagging log