r42785 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42784‎ | r42785 | r42786 >
Date:22:26, 29 October 2008
Author:tparscal
Status:old (Comments)
Tags:
Comment:
Made paths not static.
Modified paths:
  • /branches/CentralNotice-SpecialPage-Integration/CentralNotice.php (modified) (history)

Diff [purge]

Index: branches/CentralNotice-SpecialPage-Integration/CentralNotice.php
@@ -4,7 +4,7 @@
55 /// This guy gets loaded from every page on every wiki, and is heavily cached.
66 /// Its contents are small, and just load up another cached JS page, but this
77 /// allows us to update everything with a single purge. Nice, eh?
8 -$wgNoticeLoader = 'http://192.168.250.130/mediawiki-1.13.2/index.php/Special:NoticeLoader';
 8+$wgNoticeLoader = $IP . '/Special:NoticeLoader';
99
1010 /// Override these per-wiki to pass on via the loader to the text system
1111 /// for localization by language and project.
@@ -27,7 +27,7 @@
2828 /// URL prefix to the raw-text loader special.
2929 /// Project/language and timestamp epoch keys get appended to this
3030 /// via the loader stub.
31 -$wgNoticeText = 'http://192.168.250.130/mediawiki-1.13.2/index.php/Special:NoticeText';
 31+$wgNoticeText = $IP . '/Special:NoticeText';
3232
3333 /// If true, notice only displays if 'sitenotice=yes' is in the query string
3434 $wgNoticeTestMode = false;

Comments

#Comment by Brion VIBBER (talk | contribs)   23:41, 29 October 2008

$IP won't work at all here -- that's the MediaWiki base include path on the local filesystem.

Use $wgArticlePath perhaps (replace $1 with the page title).

Status & tagging log