r42544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42543‎ | r42544 | r42545 >
Date:09:55, 25 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Use wfMsgExt() on headers
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/ValidationStatistics_body.php
@@ -31,15 +31,14 @@
3232 }
3333
3434 $wgOut->addWikiText( wfMsg('validationstatistics-table') );
35 - $wgOut->addHTML( Xml::openElement( 'table', array( 'class' => 'wikitable flaggedrevs_stats_table' ) ) .
36 - "<tr>\n"
37 - );
 35+ $wgOut->addHTML( Xml::openElement( 'table', array( 'class' => 'wikitable flaggedrevs_stats_table' ) ) );
 36+ $wgOut->addHTML( "<tr>\n" );
3837 // Headings (for a positive grep result):
3938 // validationstatistics-ns, validationstatistics-total, validationstatistics-stable,
4039 // validationstatistics-latest, validationstatistics-synced, validationstatistics-old
4140 $msgs = array( 'ns', 'total', 'stable', 'latest', 'synced', 'old' ); // our headings
4241 foreach( $msgs as $msg ) {
43 - $wgOut->addHTML( Xml::element( 'th', null, wfMsg( "validationstatistics-$msg" ) ) );
 42+ $wgOut->addHTML( '<tr>' . wfMsgExt("validationstatistics-$msg",array('parseinline')) . '</tr>' );
4443 }
4544 $wgOut->addHTML( "</tr>\n" );
4645

Comments

#Comment by Voice of All (talk | contribs)   09:57, 25 October 2008

Opps, mean fixed in r42545

Status & tagging log