r42163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42162‎ | r42163 | r42164 >
Date:01:48, 17 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Fix r42155 - don't spew <x> for empty messages everywhere
Modified paths:
  • /trunk/extensions/CodeReview/CodeTagListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeTagListView.php
@@ -13,7 +13,9 @@
1414 $name = $this->mRepo->getName();
1515 $text = '';
1616 foreach( $tags as $tag ) {
17 - $text .= "* [[Special:Code/$name/tag/$tag|$tag]] - " . wfMsg( "code-status-$tag-desc" ) . "\n";
 17+ $msg = "code-status-$tag-desc";
 18+ $exp = wfEmptyMsg( $msg, wfMsg($msg) ) ? '' : ' - ' . wfMsgHtml( "code-status-$tag-desc" );
 19+ $text .= "* [[Special:Code/$name/tag/$tag|$tag]]$exp\n";
1820 }
1921 $wgOut->addWikiText( $text );
2022 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r42234Revert r42155, r42163 and friends -- doesn't do anything. Seems to confuse st...brion23:38, 19 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42155Add some descriptions to what the tags mean on the listing page. Improvements...demon20:58, 16 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   23:39, 19 October 2008

This doesn't do anything -- reverted in r42234

Status & tagging log