r42158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42157‎ | r42158 | r42159 >
Date:00:46, 17 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
(bug 16009) Remove extra title param
Modified paths:
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
@@ -297,8 +297,7 @@
298298 $attrs .= " class=\"mw-{$type}link\"" ;
299299 }
300300 return $this->getSkin()->makeKnownLinkObj( $this->getTitle(), $text,
301 - wfArrayToCGI( $query, $this->getDefaultQuery() ), '', '',
302 - $attrs );
 301+ wfArrayToCGI( $query, $this->getDefaultQuery() ), '', '', $attrs );
303302 }
304303
305304 /**
@@ -850,7 +849,7 @@
851850 "<form method=\"get\" action=\"$url\">" .
852851 wfMsgHtml( 'table_pager_limit', $this->getLimitSelect() ) .
853852 "\n<input type=\"submit\" value=\"$msgSubmit\"/>\n" .
854 - $this->getHiddenFields( 'limit' ) .
 853+ $this->getHiddenFields( array('limit','title') ) .
855854 "</form>\n";
856855 }
857856

Follow-up revisions

RevisionCommit summaryAuthorDate
r53695* (bug 16009) Limit selection forms based on Pager now links to the correct p...ialex20:18, 23 July 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   02:40, 20 October 2008

I _think_ this is safe, but it strikes me as damn suspicious that POST cases could get fouled up. Marking suspicious but ok for now. :)

Status & tagging log