r42062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42061‎ | r42062 | r42063 >
Date:23:41, 13 October 2008
Author:demon
Status:old (Comments)
Tags:
Comment:
Give some output that Brion wanted :)
Modified paths:
  • /trunk/extensions/CodeReview/ApiCodeUpdate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ApiCodeUpdate.php
@@ -30,14 +30,21 @@
3131 $log = $svn->getLog( '', $lastStoredRev + 1, $endRev );
3232 if( !$log ) {
3333 throw new MWException( "Something awry..." );
34 - }
 34+ }
3535
 36+ $result = array();
3637 foreach( $log as $data ) {
 38+ $r = array();
3739 $codeRev = CodeRevision::newFromSvn( $repo, $data );
3840 $codeRev->save();
39 - // would be nice to output something but the api code is weird
40 - // and i don't feel like figuring it out right now :)
 41+ $r['id'] = $codeRev->getId();
 42+ $r['author'] = $codeRev->getAuthor();
 43+ $r['timestamp'] = $codeRev->getTimestamp();
 44+ $r['message'] = $codeRev->getMessage();
 45+ $result[] = $r;
4146 }
 47+ $this->getResult()->setIndexedTagName($result, 'rev');
 48+ $this->getResult()->addValue(null, $this->getModuleName(), $result);
4249 }
4350
4451 public function mustBePosted() {

Comments

#Comment by Brion VIBBER (talk | contribs)   00:45, 15 October 2008

whee thanks :D

Status & tagging log