r42042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42041‎ | r42042 | r42043 >
Date:18:49, 13 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Add quotes
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -1032,7 +1032,7 @@
10331033 $res = $dbw->select( 'revision',
10341034 'rev_user',
10351035 array( 'rev_page' => $this->mArticle->getId(),
1036 - 'rev_timestamp > '.$dbw->timestamp($edittime) ),
 1036+ "rev_timestamp > '".$dbw->timestamp($edittime)."'" ),
10371037 __METHOD__,
10381038 array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 20 ) );
10391039 while( $row = $res->fetchObject() ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   19:06, 13 October 2008

use addQuotes here rather than assuming that timestamp values don't require escaping.

#Comment by Voice of All (talk | contribs)   19:08, 13 October 2008

r42044

Status & tagging log