r41869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41868‎ | r41869 | r41870 >
Date:22:32, 8 October 2008
Author:brion
Status:old
Tags:
Comment:
Tweak display for code review path (added in r41686)
* Shorten commit message fragment to 40 chars so things fit better on screen
* Move path to before message for clearer display
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/SpecialCode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/SpecialCode.php
@@ -162,7 +162,7 @@
163163 $message = trim( $value );
164164 $lines = explode( "\n", $message, 2 );
165165 $first = $lines[0];
166 - $trimmed = $wgLang->truncate( $first, 60, '...' );
 166+ $trimmed = $wgLang->truncate( $first, 40, '...' );
167167 return $this->formatMessage( $trimmed );
168168 }
169169 /*
Index: trunk/extensions/CodeReview/CodeRevisionListView.php
@@ -63,9 +63,9 @@
6464 'cr_id' => wfMsg( 'code-field-id' ),
6565 'cr_status' => wfMsg( 'code-field-status' ),
6666 'COUNT(cc_rev_id)' => wfMsg( 'code-field-comments' ),
 67+ 'cr_path' => wfMsg( 'code-field-path' ),
6768 'cr_message' => wfMsg( 'code-field-message' ),
6869 'cr_author' => wfMsg( 'code-field-author' ),
69 - 'cr_path' => wfMsg( 'code-field-path' ),
7070 'cr_timestamp' => wfMsg( 'code-field-timestamp' ),
7171 );
7272 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41686Adding a 'cr_path' field to store the common base path of the modifications (...nicdumz06:01, 5 October 2008

Status & tagging log