r41868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41867‎ | r41868 | r41869 >
Date:22:28, 8 October 2008
Author:aaron
Status:old
Tags:
Comment:
Move tag stuff above summary/path
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -44,9 +44,9 @@
4545 'code-rev-date' => $wgLang->timeanddate( $this->mRev->getTimestamp() ),
4646 'code-rev-author' => $this->authorLink( $this->mRev->getAuthor() ),
4747 'code-rev-status' => $this->statusForm(),
 48+ 'code-rev-tags' => $this->tagForm(),
4849 'code-rev-message' => $this->formatMessage( $this->mRev->getMessage() ),
4950 'code-rev-paths' => $paths,
50 - 'code-rev-tags' => $this->tagForm(),
5151 );
5252 $special = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName().'/'.$this->mRev->getId() );
5353
@@ -167,11 +167,14 @@
168168 function tagForm() {
169169 global $wgUser;
170170 $tags = $this->mRev->getTags();
171 - $list = implode( ", ",
172 - array_map(
173 - array( $this, 'formatTag' ),
174 - $tags )
175 - ) . ' ';
 171+ $list = '';
 172+ if( count($tags) ) {
 173+ $list = implode( ", ",
 174+ array_map(
 175+ array( $this, 'formatTag' ),
 176+ $tags )
 177+ ) . ' ';
 178+ }
176179 if( $wgUser->isAllowed( 'codereview-add-tag' ) ) {
177180 $list .= $this->addTagForm();
178181 }

Status & tagging log