r41831 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41830‎ | r41831 | r41832 >
Date:04:44, 8 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
(bug 15432) Contribs links at blockip. Moved "edit" message and shorten some.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -479,9 +479,11 @@
480480 private function getConvenienceLinks() {
481481 global $wgUser;
482482 $skin = $wgUser->getSkin();
483 - $links[] = $skin->makeLink ( 'MediaWiki:Ipbreason-dropdown', wfMsgHtml( 'ipb-edit-dropdown' ) );
 483+ $contribsPage = SpecialPage::getTitleFor( 'Contributions', $this->BlockAddress );
 484+ $links[] = $skin->link( $contribsPage, wfMsgHtml( 'ipb-blocklist-contibs', $this->BlockAddress ) );
484485 $links[] = $this->getUnblockLink( $skin );
485486 $links[] = $this->getBlockListLink( $skin );
 487+ $links[] = $skin->makeLink ( 'MediaWiki:Ipbreason-dropdown', wfMsgHtml( 'ipb-edit-dropdown' ) );
486488 return '<p class="mw-ipb-conveniencelinks">' . implode( ' | ', $links ) . '</p>';
487489 }
488490
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2551,8 +2551,9 @@
25522552 'ipb-edit-dropdown' => 'Edit block reasons',
25532553 'ipb-unblock-addr' => 'Unblock $1',
25542554 'ipb-unblock' => 'Unblock a username or IP address',
2555 -'ipb-blocklist-addr' => 'View existing blocks for $1',
 2555+'ipb-blocklist-addr' => 'Existing blocks for $1',
25562556 'ipb-blocklist' => 'View existing blocks',
 2557+'ipb-blocklist-contibs' => 'Contributions for $1',
25572558 'unblockip' => 'Unblock user',
25582559 'unblockiptext' => 'Use the form below to restore write access to a previously blocked IP address or username.',
25592560 'ipusubmit' => 'Unblock this address',

Follow-up revisions

RevisionCommit summaryAuthorDate
r41832Cleanup for r41831:...raymond06:44, 8 October 2008

Comments

#Comment by Mike.lifeguard (talk | contribs)   05:30, 8 October 2008

Currently links to Contributions for when no user is specified - is that OK?

#Comment by Brion VIBBER (talk | contribs)   20:45, 8 October 2008

r41832 fixes the message name typo, but the extra link is still there.

#Comment by Voice of All (talk | contribs)   21:12, 8 October 2008

Fixed in r41852

#Comment by Brion VIBBER (talk | contribs)   21:28, 8 October 2008

thanks!

Status & tagging log