r41774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41773‎ | r41774 | r41775 >
Date:20:01, 6 October 2008
Author:siebrand
Status:old (Comments)
Tags:
Comment:
Split date ($2) and time ($3) in 'protect-existing-expiry' per request of a translator. Leaving the old timestamp ($1) in for backward compatibility.
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -331,9 +331,12 @@
332332
333333 $expiryFormOptions = '';
334334 if ( $this->mExistingExpiry[$action] && $this->mExistingExpiry[$action] != 'infinity' ) {
 335+ $timestamp = $wgLang->timeanddate( $this->mExistingExpiry[$action] );
 336+ $d = $wgLang->date( $this->mExistingExpiry[$action] );
 337+ $t = $wgLang->time( $this->mExistingExpiry[$action] );
335338 $expiryFormOptions .=
336339 Xml::option(
337 - wfMsg( 'protect-existing-expiry', $wgLang->timeanddate( $this->mExistingExpiry[$action] ) ),
 340+ wfMsg( 'protect-existing-expiry', $timestamp, $d, $t ),
338341 'existing',
339342 $this->mExpirySelection[$action] == 'existing'
340343 ) . "\n";
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2388,7 +2388,7 @@
23892389 'protect-cantedit' => 'You cannot change the protection levels of this page, because you do not have permission to edit it.',
23902390 'protect-othertime' => 'Other time:',
23912391 'protect-othertime-op' => 'other time',
2392 -'protect-existing-expiry' => 'Existing expiry time: $1',
 2392+'protect-existing-expiry' => 'Existing expiry time: $3, $2',
23932393 'protect-otherreason' => 'Other/additional reason:',
23942394 'protect-otherreason-op' => 'other/additional reason',
23952395 'protect-dropdown' => '*Common protection reasons

Comments

#Comment by Brion VIBBER (talk | contribs)   00:16, 7 October 2008

backwards compat makes me warm and fuzzy inside

#Comment by Siebrand (talk | contribs)   16:13, 7 October 2008

That must be good for the environment...

Status & tagging log