r41624 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41623‎ | r41624 | r41625 >
Date:23:24, 3 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Check $wgRequest->getVal('wpSave')
Modified paths:
  • /trunk/extensions/CodeReview/SpecialCode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/SpecialCode.php
——@@ -23,7 +23,7 @@
2424 $view = new CodeRevisionListView( $params[0] );
2525 break;
2626 case 2:
27 - if( $wgRequest->wasPosted() ) {
 27+ if( $wgRequest->wasPosted() && $wgRequest->getVal('wpSave') ) {
2828 # Add any tags
2929 $crt = new CodeRevisionTagger( $params[0], $params[1] );
3030 $crt->execute();

Comments

#Comment by Brion VIBBER (talk | contribs)   23:58, 3 October 2008

This avoids saving things on preview...

On the other hand it might break submits on "enter", especially under IE. Hmm. Need to test this?

#Comment by Voice of All (talk | contribs)   00:05, 4 October 2008

Seems to work

#Comment by Brion VIBBER (talk | contribs)   00:06, 4 October 2008

yay

Status & tagging log