r41622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41621‎ | r41622 | r41623 >
Date:22:58, 3 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Make sure that empty comments can't be saved here
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevision.php
——@@ -127,6 +127,9 @@
128128 }
129129
130130 function saveComment( $text, $review, $parent=null ) {
 131+ if( !$text ) {
 132+ return 0;
 133+ }
131134 $dbw = wfGetDB( DB_MASTER );
132135 $data = $this->commentData( $text, $review, $parent );
133136 $data['cc_id'] = $dbw->nextSequenceValue( 'code_comment_cc_id' );

Comments

#Comment by Brion VIBBER (talk | contribs)   23:00, 3 October 2008

This redirects me to the revision page with #c0 fragment, kinda odd.

#Comment by Voice of All (talk | contribs)   23:02, 3 October 2008

This is more of a paranoid measure, I haven't committed the primary UI check yet (will commit with other stuff)

#Comment by Voice of All (talk | contribs)   23:00, 3 October 2008
#Comment by Brion VIBBER (talk | contribs)   23:03, 3 October 2008

turns up the volume to hear

#Comment by Voice of All (talk | contribs)   00:07, 4 October 2008

Resolved in r41623

Status & tagging log