r41590 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41589‎ | r41590 | r41591 >
Date:06:55, 3 October 2008
Author:nicdumz
Status:old (Comments)
Tags:
Comment:
Add LC_MESSAGES=C in svn commandline : we don't want any localization since we're comparing messages
Modified paths:
  • /trunk/extensions/CodeReview/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/Subversion.php
@@ -109,7 +109,7 @@
110110
111111 function getLog( $path, $startRev=null, $endRev=null ) {
112112 $command = sprintf(
113 - "svn log -v -r%s:%s --non-interactive %s",
 113+ "LC_MESSAGES=C svn log -v -r%s:%s --non-interactive %s",
114114 wfEscapeShellArg( $this->_rev( $startRev, 'BASE' ) ),
115115 wfEscapeShellArg( $this->_rev( $endRev, 'HEAD' ) ),
116116 wfEscapeShellArg( $this->mRepo . $path ) );
@@ -159,7 +159,7 @@
160160 $state = 'changedpaths';
161161 break;
162162 case "changedpaths":
163 - if( $line == "Changed paths:" ) {
 163+ if( $line == "Changed paths:" ) { // broken when svn messages are not in English
164164 $state = "path";
165165 } elseif( $line == "" ) {
166166 // No changed paths?

Follow-up revisions

RevisionCommit summaryAuthorDate
r41891Revert r41590, breaks importaaron20:04, 9 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   01:16, 13 October 2008

r41891 reverted the LC_MESSAGES, it causes trouble for some.

Status & tagging log