r41339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41338‎ | r41339 | r41340 >
Date:08:22, 28 September 2008
Author:nikerabbit
Status:old (Comments)
Tags:
Comment:
+* (bug 15158) Userinvalidcssjstitle not shown on preview
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -229,6 +229,7 @@
230230 * Fixed incorrect usage of DB_LAST in Special:Export. Deprecated DB_LAST.
231231 * (bug 15642) Blocked sysops can no longer block other users
232232 * Http::request() now respects $wgHTTPtimeout when not using cURL
 233+* (bug 15158) Userinvalidcssjstitle not shown on preview
233234
234235 === API changes in 1.14 ===
235236
Index: trunk/phase3/includes/EditPage.php
@@ -1175,7 +1175,7 @@
11761176 } elseif ( $wgUser->isAnon() && $this->formtype != 'preview' ) {
11771177 $wgOut->wrapWikiMsg( '<div id="mw-anon-edit-warning">$1</div>', 'anoneditwarning' );
11781178 } else {
1179 - if ( $this->isCssJsSubpage && $this->formtype != 'preview' ) {
 1179+ if ( $this->isCssJsSubpage ) {
11801180 # Check the skin exists
11811181 if ( $this->isValidCssJsSubpage ) {
11821182 $wgOut->addWikiMsg( 'usercssjsyoucanpreview' );

Comments

#Comment by Brion VIBBER (talk | contribs)   23:56, 30 September 2008

Some remaining issues noted on bug 15158...

#Comment by Nikerabbit (talk | contribs)   07:20, 4 October 2008

See r41346.

Status & tagging log