r41337 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41336‎ | r41337 | r41338 >
Date:04:20, 28 September 2008
Author:tstarling
Status:old (Comments)
Tags:
Comment:
In wasDeletedSinceLastEdit(): fix odd string comparison method, there's an operator for that
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -326,8 +326,8 @@
327327 if ( $this->mTitle->isDeleted() ) {
328328 $this->lastDelete = $this->getLastDelete();
329329 if ( $this->lastDelete ) {
330 - $deletetime = wfTimestamp( TS_MW, $this->lastDelete->log_timestamp );
331 - if ( ($deletetime - $this->starttime) > 0 ) {
 330+ $deleteTime = wfTimestamp( TS_MW, $this->lastDelete->log_timestamp );
 331+ if ( $deleteTime > $this->starttime ) {
332332 $this->deletedSinceEdit = true;
333333 }
334334 }

Comments

#Comment by Brion VIBBER (talk | contribs)   23:38, 30 September 2008

(This revision is currently live as primary MediaWiki)

Status & tagging log