r41068 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41067‎ | r41068 | r41069 >
Date:13:14, 20 September 2008
Author:ashley
Status:old
Tags:
Comment:
SocialProfile version 1.3 release:
*Schema change - users updating from earlier versions of SocialProfile extension will need to create the four new tables manually. Also updated the installer script.
*Awards (SystemGifts) functionality
*Gifting (UserGifts) functionality
*Some default award images are included in the new awards/ directory that can be used as award images
*Fix a fair bunch of E_STRICTs & E_NOTICEs (and introduce some new. If someone knows how to fix the new & existing E_NOTICEs without breaking functionality, feel free to do so. I ended up breaking functionality in my own tests)
*Remove 'message documentation' nonsense from i18n files - there is absolutely no reason to to bloat the i18n files even further. Create http://www.mediawiki.org/wiki/Extension:SocialProfile/Message_documentation or something since MediaWiki.org is the place for in-depth documentation. I'm not going to support or approve site-specific cruft such as this.
*Other miscellaneous fixes & tweaks

Note that the special pages based on SpecialUpload.php (SpecialAvatarUpload.php, SpecialGiftManagerLogo.php, SpecialSystemGiftManagerLogo.php) will probably not work on HEAD revision of MW due to upload form changes and thus they need some updating.
Modified paths:
  • /trunk/extensions/SocialProfile/README (modified) (history)
  • /trunk/extensions/SocialProfile/SocialProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/SystemGifts (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialPopulateAwards.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialSystemGiftManager.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialSystemGiftManagerLogo.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialViewSystemGift.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SpecialViewSystemGifts.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SystemGift.css (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SystemGift.i18n.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SystemGifts.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SystemGiftsClass.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/TopAwards.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/UserSystemGiftsClass.php (added) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/systemgifts.sql (added) (history)
  • /trunk/extensions/SocialProfile/UserBoard/UserBoard.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserGifts (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/Gifts.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/GiftsClass.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialGiftManager.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialGiftManagerLogo.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialGiveGift.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialRemoveGift.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialRemoveMasterGift.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialViewGift.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/SpecialViewGifts.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/UserGifts.css (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/UserGifts.i18n.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/UserGifts.js (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/UserGiftsClass.php (added) (history)
  • /trunk/extensions/SocialProfile/UserGifts/usergifts.sql (added) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUpdateProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUploadAvatar.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserRelationship/UserRelationship.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/SpecialUpdateEditCounts.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/TopFansByStat.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/TopFansRecent.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/TopUsers.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/UserStats.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/UserStatsClass.php (modified) (history)
  • /trunk/extensions/SocialProfile/awards (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_100.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_1000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_2000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_25.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_250.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_3000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_4000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_5.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_50.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_500.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_5000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_750.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/CommentsAward_8000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_100.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_1000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_2000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_25.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_250.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_3000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_4000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_5.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_50.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_500.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_5000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_750.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/EditsAward_8000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_100.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_1000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_2000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_25.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_250.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_3000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_4000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_5.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_50.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_500.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_5000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_750.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/FriendsAward_8000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/RecruitAward5.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/RecruitAward_1.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/RecruitAward_3.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_100.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_1000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_10000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_2000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_20000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_250.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_3000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_30000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_40000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_5.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_500.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_5000.gif (added) (history)
  • /trunk/extensions/SocialProfile/awards/VotesAward_750.gif (added) (history)
  • /trunk/extensions/SocialProfile/install.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r41325partial revert of r41324. kindly refer to the commit message of r41068 for de...ashley23:35, 27 September 2008
r42224partial revert of r42223; again refer to the commit message of r41068. Please...ashley11:01, 19 October 2008