r40971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40970‎ | r40971 | r40972 >
Date:02:51, 18 September 2008
Author:demon
Status:old
Tags:
Comment:
(bug 15200) Add plural support for centralauth-editset-badwikis
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.i18n.php (modified) (history)
  • /trunk/extensions/CentralAuth/SpecialEditWikiSets.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialEditWikiSets.php
@@ -174,7 +174,7 @@
175175 if( !in_array( $wiki, $allwikis ) )
176176 $badwikis[] = $wiki;
177177 if( $badwikis ) {
178 - $this->buildSetView( $id, wfMsgExt( 'centralauth-editset-badwikis', array( 'escapenoentities' ), implode( ', ', $badwikis ) ),
 178+ $this->buildSetView( $id, wfMsgExt( 'centralauth-editset-badwikis', array( 'escapenoentities' ), array( implode( ', ', $badwikis ), count( $badwikis ) ),
179179 $name, $type, $wikis, $reason );
180180 return;
181181 }
Index: trunk/extensions/CentralAuth/CentralAuth.i18n.php
@@ -312,7 +312,7 @@
313313 'centralauth-editset-grouplink' => '[[Special:GlobalGroupPermissions/$1|$1]]',
314314 'centralauth-editset-nouse' => '(none)',
315315 'centralauth-editset-usage' => 'Used in groups:',
316 - 'centralauth-editset-badwikis' => 'Following wikis do not exist: $1.',
 316+ 'centralauth-editset-badwikis' => 'The following {{PLURAL:$2|wiki does not|wikis do not}} exist: $1.',
317317 'centralauth-editset-success' => 'Successfully changed wiki set.',
318318 'centralauth-editset-return' => 'Return to main view',
319319

Follow-up revisions

RevisionCommit summaryAuthorDate
r40982Revert r40971, which had a syntax error. Please *at least*, check code for sy...werdna13:52, 18 September 2008

Status & tagging log