r40962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40961‎ | r40962 | r40963 >
Date:18:36, 17 September 2008
Author:ialex
Status:old
Tags:
Comment:
Fix for r40937 (and per talk with brion): merge the RenderHash extension in core
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2442,7 +2442,7 @@
24432443 * @return \type{\string} Page rendering hash
24442444 */
24452445 function getPageRenderingHash() {
2446 - global $wgContLang, $wgUseDynamicDates, $wgLang;
 2446+ global $wgUseDynamicDates, $wgRenderHashAppend, $wgLang, $wgContLang;
24472447 if( $this->mHash ){
24482448 return $this->mHash;
24492449 }
@@ -2462,6 +2462,8 @@
24632463 $extra = $wgContLang->getExtraHashOptions();
24642464 $confstr .= $extra;
24652465
 2466+ $confstr .= $wgRenderHashAppend;
 2467+
24662468 // Give a chance for extensions to modify the hash, if they have
24672469 // extra options or other effects on the parser cache.
24682470 wfRunHooks( 'PageRenderingHash', array( &$confstr ) );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1037,6 +1037,12 @@
10381038 $wgEnableParserCache = true;
10391039
10401040 /**
 1041+ * Append a configured value to the parser cache and the sitenotice key so
 1042+ * that they can be kept separate for some class of activity.
 1043+ */
 1044+$wgRenderHashAppend = '';
 1045+
 1046+/**
10411047 * If on, the sidebar navigation links are cached for users with the
10421048 * current language set. This can save a touch of load on a busy site
10431049 * by shaving off extra message lookups.

Follow-up revisions

RevisionCommit summaryAuthorDate
r40964Obsolete per r40962ialex18:45, 17 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40937* (bug 10463) Apply $wgRenderHashAppend to sitenotice cache keys so SSL and n...brion21:14, 16 September 2008