r40806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40805‎ | r40806 | r40807 >
Date:02:29, 14 September 2008
Author:krimpet
Status:old
Tags:
Comment:
Make NewUserMessage always use EDIT_SUPPRESS_RC, instead of making this an option; the way it 'parks' users confuses CheckUser and friends.
Modified paths:
  • /trunk/extensions/NewUserMessage/NewUserMessage.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/NewUserMessage/NewUserMessage.class.php
@@ -21,7 +21,7 @@
2222 $talk = $user->getTalkPage();
2323
2424 if (!$talk->exists()) {
25 - global $wgUser, $wgNewUserMinorEdit, $wgNewUserSuppressRC;
 25+ global $wgUser, $wgNewUserMinorEdit;
2626
2727 wfLoadExtensionMessages( 'NewUserMessage' );
2828
@@ -37,7 +37,7 @@
3838 $wgUser->addToDatabase();
3939 }
4040
41 - $flags = EDIT_NEW;
 41+ $flags = EDIT_NEW | EDIT_SUPPRESS_RC;
4242 $templateTitleText = wfMsg( 'newusermessage-template' );
4343 $templateTitle = Title::newFromText( $templateTitleText );
4444 if ( !$templateTitle ) {
@@ -48,7 +48,6 @@
4949 $templateTitleText = $templateTitle->getText();
5050 }
5151 if ($wgNewUserMinorEdit) $flags = $flags | EDIT_MINOR;
52 - if ($wgNewUserSuppressRC) $flags = $flags | EDIT_SUPPRESS_RC;
5352
5453 $dbw = wfGetDB( DB_MASTER );
5554 $dbw->begin();

Follow-up revisions

RevisionCommit summaryAuthorDate
r40846Revert r40806 (never use RC). Use the $user parameter to Article::doEdit() in...tstarling05:46, 15 September 2008