r40753 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40752‎ | r40753 | r40754 >
Date:15:10, 12 September 2008
Author:aaron
Status:reverted
Tags:
Comment:
Use wfEscapeShellArg() since it works on windows (bug 13518)
Modified paths:
  • /trunk/phase3/includes/Math.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Math.php
@@ -58,14 +58,14 @@
5959 return $this->_error( 'math_notexvc' );
6060 }
6161 $cmd = $wgTexvc . ' ' .
62 - escapeshellarg( $wgTmpDirectory ).' '.
63 - escapeshellarg( $wgTmpDirectory ).' '.
64 - escapeshellarg( $this->tex ).' '.
65 - escapeshellarg( $wgInputEncoding );
 62+ wfEscapeShellArg( $wgTmpDirectory ).' '.
 63+ wfEscapeShellArg( $wgTmpDirectory ).' '.
 64+ wfEscapeShellArg( $this->tex ).' '.
 65+ wfEscapeShellArg( $wgInputEncoding );
6666
6767 if ( wfIsWindows() ) {
6868 # Invoke it within cygwin sh, because texvc expects sh features in its default shell
69 - $cmd = 'sh -c ' . wfEscapeShellArg( $cmd );
 69+ $cmd = 'sh -c ' . wfwfEscapeShellArg( $cmd );
7070 }
7171
7272 wfDebug( "TeX: $cmd\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r40956Bah, revert to r40753aaron12:36, 17 September 2008
r103473wfEscapeSingleQuotes() change proposed by Ralf Lederle in...platonides16:25, 17 November 2011

Status & tagging log