r40628 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40627‎ | r40628 | r40629 >
Date:23:33, 8 September 2008
Author:soxred93
Status:old
Tags:
Comment:
Fix action=rollback to now revert IPs too. Patch submitted by ST47.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiRollback.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiRollback.php
@@ -55,7 +55,10 @@
5656 if(!$titleObj->exists())
5757 $this->dieUsageMsg(array('notanarticle'));
5858
59 - $username = User::getCanonicalName($params['user']);
 59+ #We need to be able to revert IPs, but getCanonicalName rejects them
 60+ $username = User::isIP($params['user'])
 61+ ? $params['user']
 62+ : User::getCanonicalName($params['user']);
6063 if(!$username)
6164 $this->dieUsageMsg(array('invaliduser', $params['user']));
6265
Index: trunk/phase3/RELEASE-NOTES
@@ -222,6 +222,7 @@
223223 * (bug 15466) Added action=purge
224224 * (bug 15486) action=block ignores autoblock parameter
225225 * (bug 15492) added rcprop=loginfo to list=recentchanges
 226+* (bug 15527) action=rollback can now revert anonymous editors
226227
227228 === Languages updated in 1.14 ===
228229

Follow-up revisions

RevisionCommit summaryAuthorDate
r40629Add ST47 to CREDITS for r40628...simetrical23:45, 8 September 2008