r39787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39786‎ | r39787 | r39788 >
Date:20:33, 21 August 2008
Author:demon
Status:old (Comments)
Tags:i18nreview 
Comment:
Grammar tweak (bug 14239)
Modified paths:
  • /trunk/extensions/GlobalBlocking/GlobalBlocking.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/GlobalBlocking.i18n.php
——@@ -78,7 +78,7 @@
7979 'globalblocking-whitelist-intro' => "You can use this form to edit the local status of a global block. If a global block is disabled on this wiki, users on the affected IP address will be able to edit normally. [[Special:Globalblocklist|Click here]] to return to the global block list.",
8080
8181 'globalblocking-blocked' => "Your IP address has been blocked on all wikis by '''$1''' (''$2'').
82 -The reason given was ''\"$3\"''. The block's expiry is ''$4''.",
 82+The reason given was ''\"$3\"''. The block ''$4''.",
8383
8484 'globalblocking-logpage' => 'Global block log',
8585 'globalblocking-block-logentry' => 'globally blocked [[$1]] with an expiry time of $2 ($3)',

Follow-up revisions

RevisionCommit summaryAuthorDate
r114093* Follow-up r39787: Fix issue with message in case a block will not expire (i...siebrand06:55, 18 March 2012

Comments

#Comment by Siebrand (talk | contribs)   14:26, 9 September 2011

translatewiki:Thread:Support/About_MediaWiki:Globalblocking-blocked/en.

Substitution of the parameter $4 results in an ungrammatical sentence ("The block infinite") if $4 is the contents of Infiniteblock ("infinite").

#Comment by 😂 (talk | contribs)   14:27, 9 September 2011

Grr. Suggestions?

#Comment by Siebrand (talk | contribs)   14:51, 9 September 2011

Two messages? One when having an expiry date, one when indefinite? Haven't looked (yet), but I assume local blocking code has a solution...

#Comment by 😂 (talk | contribs)   14:54, 9 September 2011

(auto)blockedtext both do something like this: 

The block was made by $1.
The reason given is ''$2''.

* Start of block: $8
* Expiry of block: $6
* Intended blockee: $7
#Comment by Platonides (talk | contribs)   14:43, 9 September 2011

How is bug 14239 related to this?

#Comment by 😂 (talk | contribs)   14:46, 9 September 2011

It obviously isn't. Must've been a typo, but it was over 3 years ago so I forgot :)

#Comment by Platonides (talk | contribs)   14:48, 9 September 2011

Ok, I'll admit your excuse :) I hadn't noticed it was so old!

#Comment by Siebrand (talk | contribs)   09:42, 13 September 2011

Meno25, why was the fixme set back to old? Does it state somewhere that bugs identified in revisions marked old cannot be FIXMEd? Please put the fixme back on.

#Comment by Nikerabbit (talk | contribs)   21:46, 9 October 2011

Correct is bug 15259.

Status & tagging log