r39657 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39656‎ | r39657 | r39658 >
Date:19:11, 19 August 2008
Author:brion
Status:old
Tags:
Comment:
Revert r39625 "Run autocreated accounts through AbortNewAccount hooks"
This seems to be mixing UI and backend code.

Further I'm unsure we want to treat authplugin autocreations as "new accounts" for this purpose; since they *have* been previously created and perhaps approved, just blindly running it through the same abort hook again will be a huge pain in the butt, for instance for those who had to go through admin approval due to a machine-detected name spoof conflict or an IP blocking issue. If an abort is appropriate, it should probably be a distinct hook so it can be treated differently.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -500,14 +500,6 @@
501501 return self::CREATE_BLOCKED;
502502 }
503503
504 - $abortError = '';
505 - if( !wfRunHooks( 'AbortNewAccount', array( $user->getName(), &$abortError ) ) ) {
506 - // Hook point to add extra creation throttles and blocks
507 - wfDebug( __METHOD__.": a hook blocked creation\n" );
508 - $this->mainLoginForm( $abortError );
509 - return self::ABORTED;
510 - }
511 -
512504 wfDebug( __METHOD__.": creating account\n" );
513505 $user = $this->initUser( $user, true );
514506 return self::SUCCESS;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39625Run autocreated accounts through AbortNewAccount hookskrimpet02:00, 19 August 2008

Status & tagging log