r39656 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39655‎ | r39656 | r39657 >
Date:19:10, 19 August 2008
Author:demon
Status:old
Tags:
Comment:
Move the call to view() for Action::purge() up from doPurge() to purge(). Kinda like last time, only less broken. Calling Article::doPurge() now lets the backend do a purge without output (and doesn't turn Article::purge() into a UI and backend entry, which is good)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -1044,6 +1044,7 @@
10451045 if ( $wgUser->isAllowed( 'purge' ) || $wgRequest->wasPosted() ) {
10461046 if( wfRunHooks( 'ArticlePurge', array( &$this ) ) ) {
10471047 $this->doPurge();
 1048+ $this->view();
10481049 }
10491050 } else {
10501051 $msg = $wgOut->parse( wfMsg( 'confirm_purge' ) );
——@@ -1086,7 +1087,6 @@
10871088 }
10881089 $wgMessageCache->replace( $this->mTitle->getDBkey(), $text );
10891090 }
1090 - $this->view();
10911091 }
10921092
10931093 /**

Status & tagging log