r39617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39616‎ | r39617 | r39618 >
Date:21:17, 18 August 2008
Author:brion
Status:old
Tags:
Comment:
Revert r39398 "(bug 14971) Added method for alphabetical ordering ('alphabetical') (patch by Ramac)"
This patch will pretty obviously fail in combination with various other query options; it adds an ORDER BY to the where clause in the middle of other options.
Modified paths:
  • /trunk/extensions/intersection/DynamicPageList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/intersection/DynamicPageList.php
@@ -1,6 +1,6 @@
22 <?php
33 /*
4 -
 4+
55 Purpose: outputs a bulleted list of most recent
66 items residing in a category, or a union
77 of several categories.
@@ -195,9 +195,6 @@
196196 case 'lastedit':
197197 $sOrderMethod = 'lastedit';
198198 break;
199 - case 'alphabetical':
200 - $sOrderMethod = 'alphabetical';
201 - break;
202199 case 'categoryadd':
203200 default:
204201 $sOrderMethod = 'categoryadd';
@@ -334,7 +331,7 @@
335332 $sSqlWhere = ' WHERE page_namespace='.$iNamespace.' ';
336333 else
337334 $sSqlWhere = ' WHERE 1=1 ';
338 -
 335+
339336 // Bug 14943 - Allow filtering based on FlaggedRevs stability.
340337 // Check if the extension actually exists before changing the query...
341338 if( function_exists('efLoadFlaggedRevs') ) {
@@ -344,10 +341,6 @@
345342 if( in_array($sStable,$filterSet) || in_array($sQuality,$filterSet) ) {
346343 $sSqlSelectFrom .= " LEFT JOIN $flaggedpages ON page_id = fp_page_id";
347344 }
348 - else if ('alphabetical' == $sOrderMethod) {
349 - $sSqlWhere .= ' ORDER BY page_title ';
350 - }
351 -
352345 switch( $sStable )
353346 {
354347 case 'only':

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39398(bug 14971) Added method for alphabetical ordering ('alphabetical') (patch by...siebrand08:06, 15 August 2008

Status & tagging log