r39616 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39615‎ | r39616 | r39617 >
Date:21:03, 18 August 2008
Author:aaron
Status:old
Tags:
Comment:
Use !== here
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -4678,7 +4678,7 @@
46794679 do {
46804680 $oldText = $text;
46814681 $text = $this->general->replace( $text );
4682 - } while ( $text != $oldText );
 4682+ } while ( $text !== $oldText );
46834683 wfProfileOut( __METHOD__ );
46844684 return $text;
46854685 }
@@ -4688,7 +4688,7 @@
46894689 do {
46904690 $oldText = $text;
46914691 $text = $this->nowiki->replace( $text );
4692 - } while ( $text != $oldText );
 4692+ } while ( $text !== $oldText );
46934693 wfProfileOut( __METHOD__ );
46944694 return $text;
46954695 }
@@ -4699,7 +4699,7 @@
47004700 $oldText = $text;
47014701 $text = $this->general->replace( $text );
47024702 $text = $this->nowiki->replace( $text );
4703 - } while ( $text != $oldText );
 4703+ } while ( $text !== $oldText );
47044704 wfProfileOut( __METHOD__ );
47054705 return $text;
47064706 }

Status & tagging log