r39501 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39500‎ | r39501 | r39502 >
Date:21:00, 16 August 2008
Author:catrope
Status:old
Tags:
Comment:
API: Let list=search throw away missing titles. Lucene will sometimes give us pages that have recently been deleted.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySearch.php
@@ -93,8 +93,9 @@
9494 break;
9595 }
9696
97 - // Silently skip broken titles
98 - if ($result->isBrokenTitle()) continue;
 97+ // Silently skip broken and missing titles
 98+ if ($result->isBrokenTitle() || $result->isMissingRevision())
 99+ continue;
99100
100101 $title = $result->getTitle();
101102 if (is_null($resultPageSet)) {
Index: trunk/phase3/RELEASE-NOTES
@@ -148,6 +148,7 @@
149149 * (bug 15048) Added limit field for multivalue parameters to action=paraminfo
150150 output.
151151 * When the limit on multivalue parameters is exceeded, a warning is issued
 152+* list=search doesn't list missing pages any more
152153
153154 === Languages updated in 1.14 ===
154155

Status & tagging log