r39500 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39499‎ | r39500 | r39501 >
Date:20:52, 16 August 2008
Author:catrope
Status:old
Tags:
Comment:
API: Fixing an E_NOTICE reported by Wikia. Can't reproduce locally, but an extra @ can't hurt.
Modified paths:
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuery.php
@@ -229,8 +229,8 @@
230230 * Create instances of all modules requested by the client
231231 */
232232 private function InstantiateModules(&$modules, $param, $moduleList) {
233 - $list = $this->params[$param];
234 - if (isset ($list))
 233+ $list = @$this->params[$param];
 234+ if (!is_null ($list))
235235 foreach ($list as $moduleName)
236236 $modules[] = new $moduleList[$moduleName] ($this, $moduleName);
237237 }

Status & tagging log