r38988 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38987‎ | r38988 | r38989 >
Date:10:49, 9 August 2008
Author:rotem
Status:old
Tags:
Comment:
Removing the warning of call-time pass-by-reference; change tested this time.
Modified paths:
  • /trunk/extensions/Translate/MessageChecks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageChecks.php
@@ -57,7 +57,7 @@
5858
5959 foreach ( $this->checksForType[$type] as $check ) {
6060 $warning = '';
61 - if ( call_user_func( array($this, $check), $message, $code, &$warning ) ) {
 61+ if ( $this->$check( $message, $code, $warning ) ) {
6262 $warnings[] = $warning;
6363 }
6464 }
@@ -69,7 +69,7 @@
7070 if ( $message->translation === null) return false;
7171
7272 foreach ( $this->checksForType[$type] as $check ) {
73 - if ( call_user_func( array($this, $check), $message, $code ) ) return true;
 73+ if ( $this->$check( $message, $code ) ) return true;
7474 }
7575
7676 return false;

Status & tagging log