r38869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38868‎ | r38869 | r38870 >
Date:09:37, 8 August 2008
Author:tstarling
Status:old
Tags:
Comment:
Don't limit setlocale() hack to PHP 5.2.6, as per comment on bug 14944.
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -118,10 +118,8 @@
119119 * Workaround for http://bugs.php.net/bug.php?id=45132
120120 * escapeshellarg() destroys non-ASCII characters if LANG is not a UTF-8 locale
121121 */
122 -if ( version_compare( PHP_VERSION, '5.2.6', '>=' ) ) {
123 - putenv( 'LC_CTYPE=en_US.UTF-8' );
124 - setlocale( LC_CTYPE, 'en_US.UTF-8' );
125 -}
 122+putenv( 'LC_CTYPE=en_US.UTF-8' );
 123+setlocale( LC_CTYPE, 'en_US.UTF-8' );
126124
127125 if ( !class_exists( 'AutoLoader' ) ) {
128126 require_once( "$IP/includes/AutoLoader.php" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r38873Backport r38869tstarling10:19, 8 August 2008
r41379Proposed fix for bug 14944, specifically the reports that some servers do not...tstarling10:19, 29 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38837Backported the following:...tstarling04:02, 8 August 2008

Status & tagging log