r38771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38770‎ | r38771 | r38772 >
Date:12:19, 7 August 2008
Author:raymond
Status:old
Tags:
Comment:
Make space after semicolon consistent with other punctuation marks
Fixes an inconsistency on Special:Whatlinkshere like "Image:Name.jpg (redirect page;image link) (← links)" too
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesArz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKk_arab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKu_arab.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -201,7 +201,7 @@
202202 protected function insertTimestamp(&$s, $rc) {
203203 global $wgLang;
204204 # Timestamp
205 - $s .= $this->message['semicolon-separator'] . ' ' . $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
 205+ $s .= $this->message['semicolon-separator'] . $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
206206 }
207207
208208 /** Insert links to user page, user talk page and eventually a blocking link */
@@ -592,7 +592,7 @@
593593 array_push( $users, $text );
594594 }
595595
596 - $users = ' <span class="changedby">[' . implode( $this->message['semicolon-separator'] . ' ', $users ) . ']</span>';
 596+ $users = ' <span class="changedby">[' . implode( $this->message['semicolon-separator'], $users ) . ']</span>';
597597
598598 # Arrow
599599 $rci = 'RCI'.$this->rcCacheIndex;
@@ -712,7 +712,7 @@
713713 if ( !$rc_type == RC_LOG || $rc_type == RC_NEW ) {
714714 $r .= ' (';
715715 $r .= $rcObj->curlink;
716 - $r .= $this->message['semicolon-separator'] . ' ';
 716+ $r .= $this->message['semicolon-separator'];
717717 $r .= $rcObj->lastlink;
718718 $r .= ')';
719719 }
@@ -837,7 +837,7 @@
838838
839839 # Diff and hist links
840840 if ( $rc_type != RC_LOG ) {
841 - $r .= ' ('. $rcObj->difflink . $this->message['semicolon-separator'] . ' ';
 841+ $r .= ' ('. $rcObj->difflink . $this->message['semicolon-separator'];
842842 $r .= $this->skin->makeKnownLinkObj( $rcObj->getTitle(), wfMsg( 'hist' ), $curIdEq.'&action=history' ) . ')';
843843 }
844844 $r .= ' . . ';
Index: trunk/phase3/languages/messages/MessagesKu_arab.php
@@ -340,8 +340,8 @@
341341 'tooltip-pt-userpage' => 'په‌ڕه‌ی تایبه‌تی خۆم',
342342
343343 # Separators for various lists, etc.
344 -'semicolon-separator' => '؛',
345 -'comma-separator' => '،',
 344+'semicolon-separator' => '؛&#32;',
 345+'comma-separator' => '،&#32;',
346346
347347 # Live preview
348348 'livepreview-loading' => 'له‌باركردنایه‌ ...',
Index: trunk/phase3/languages/messages/MessagesAr.php
@@ -2927,8 +2927,8 @@
29282928 'useajaxsearch' => 'استخدم بحث أجاكس',
29292929
29302930 # Separators for various lists, etc.
2931 -'semicolon-separator' => '؛',
2932 -'comma-separator' => '،',
 2931+'semicolon-separator' => '؛&#32;',
 2932+'comma-separator' => '،&#32;',
29332933
29342934 # Multipage image navigation
29352935 'imgmultipageprev' => '← الصفحة السابقة',
Index: trunk/phase3/languages/messages/MessagesKk_arab.php
@@ -2879,7 +2879,7 @@
28802880 'useajaxsearch' => 'AJAX قولدانىپ ىزدەۋ',
28812881
28822882 # Separators for various lists, etc.
2883 -'semicolon-separator' => '؛',
 2883+'semicolon-separator' => '؛&#32;',
28842884 'comma-separator' => '،&#32;',
28852885
28862886 # Multipage image navigation
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3271,7 +3271,7 @@
32723272
32733273 # Separators for various lists, etc.
32743274 'catseparator' => '|', # only translate this message to other languages if you have to change it
3275 -'semicolon-separator' => ';', # only translate this message to other languages if you have to change it
 3275+'semicolon-separator' => ';&#32;', # only translate this message to other languages if you have to change it
32763276 'comma-separator' => ',&#32;', # only translate this message to other languages if you have to change it
32773277 'colon-separator' => ':&#32;', # only translate this message to other languages if you have to change it
32783278 'autocomment-prefix' => '-&#32;', # only translate this message to other languages if you have to change it
Index: trunk/phase3/languages/messages/MessagesFa.php
@@ -2694,7 +2694,7 @@
26952695 'useajaxsearch' => 'از جستجوی مبتنی بر AJAX استفاده کن',
26962696
26972697 # Separators for various lists, etc.
2698 -'semicolon-separator' => '؛',
 2698+'semicolon-separator' => '؛&#32;',
26992699 'comma-separator' => '،&#32;',
27002700
27012701 # Multipage image navigation
Index: trunk/phase3/languages/messages/MessagesArz.php
@@ -2718,9 +2718,9 @@
27192719 'useajaxsearch' => 'دور بـ أجاكس',
27202720
27212721 # Separators for various lists, etc.
2722 -'semicolon-separator' => '؛',
2723 -'comma-separator' => '،',
2724 -'autocomment-prefix' => '-',
 2722+'semicolon-separator' => '؛&#32;',
 2723+'comma-separator' => '،&#32;',
 2724+'autocomment-prefix' => '-&#32;',
27252725
27262726 # Multipage image navigation
27272727 'imgmultipageprev' => '← الصفحة اللي فاتت',

Follow-up revisions

RevisionCommit summaryAuthorDate
r38780Follow up for r38771.raymond14:11, 7 August 2008

Status & tagging log