r38714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38713‎ | r38714 | r38715 >
Date:14:17, 6 August 2008
Author:tstarling
Status:old
Tags:
Comment:
Add support for mplayerplug-in, yet another browser plugin with a fake QuickTime.
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler.i18n.php (modified) (history)
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)
  • /trunk/extensions/OggHandler/OggPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggPlayer.js
@@ -8,7 +8,7 @@
99
1010 // List of players in order of preference
1111 // Downpreffed VLC because it crashes my browser all the damn time -- TS
12 - 'players': ['cortado', 'quicktime-mozilla', 'quicktime-activex', 'vlc-mozilla', 'vlc-activex', 'totem', 'kmplayer', 'kaffeine', 'oggPlugin', 'videoElement'],
 12+ 'players': ['cortado', 'quicktime-mozilla', 'quicktime-activex', 'vlc-mozilla', 'vlc-activex', 'totem', 'kmplayer', 'kaffeine', 'mplayerplug-in', 'oggPlugin', 'videoElement'],
1313
1414 // Client support table
1515 'clientSupports': { 'thumbnail' : true },
@@ -22,7 +22,8 @@
2323 'oggPlugin': 'application/ogg',
2424 'totem': 'application/ogg',
2525 'kmplayer': 'application/ogg',
26 - 'kaffeine': 'application/ogg'
 26+ 'kaffeine': 'application/ogg',
 27+ 'mplayerplug-in': 'application/ogg'
2728 },
2829
2930 'savedThumbs': {},
@@ -31,7 +32,8 @@
3233 'defaultMsg' : {
3334 'ogg-player-totem': 'Totem',
3435 'ogg-player-kmplayer': 'KMPlayer',
35 - 'ogg-player-kaffeine': 'Kaffeine'
 36+ 'ogg-player-kaffeine': 'Kaffeine',
 37+ 'ogg-player-mplayerplug-in': 'mplayerplug-in'
3638 },
3739
3840 // Configuration from MW
@@ -91,6 +93,7 @@
9294 case 'kaffeine':
9395 case 'totem':
9496 case 'kmplayer':
 97+ case 'mplayerplug-in':
9598 this.embedOggPlugin( elt, params, player );
9699 break;
97100 case 'vlc-mozilla':
@@ -233,6 +236,11 @@
234237 } else if ( pluginFilename.indexOf( 'kaffeineplugin' ) > -1 ) {
235238 // Kaffeine
236239 player = 'kaffeine';
 240+ } else if ( pluginName.indexOf( 'mplayerplug-in' ) > -1 ) {
 241+ player = 'mplayerplug-in';
 242+ } else if ( pluginFilename.indexOf( 'mplayerplug-in-qt' ) > -1 ) {
 243+ // MPlayer fake QuickTime
 244+ player = '';
237245 } else if ( pluginName.indexOf( 'QuickTime Plug-in' ) > -1 ) {
238246 // Note: Totem and KMPlayer also use this pluginName, which is
239247 // why we check for them first
Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -400,7 +400,7 @@
401401 $msgNames = array( 'ogg-play', 'ogg-pause', 'ogg-stop', 'ogg-no-player',
402402 'ogg-player-videoElement', 'ogg-player-oggPlugin', 'ogg-player-cortado', 'ogg-player-vlc-mozilla',
403403 'ogg-player-vlc-activex', 'ogg-player-quicktime-mozilla', 'ogg-player-quicktime-activex',
404 - 'ogg-player-totem', 'ogg-player-kaffeine', 'ogg-player-kmplayer',
 404+ 'ogg-player-totem', 'ogg-player-kaffeine', 'ogg-player-kmplayer', 'ogg-player-mplayerplug-in',
405405 'ogg-player-thumbnail', 'ogg-player-selected', 'ogg-use-player', 'ogg-more', 'ogg-download',
406406 'ogg-desc-link', 'ogg-dismiss', 'ogg-player-soundthumb', 'ogg-no-xiphqt' );
407407 $msgValues = array_map( 'wfMsg', $msgNames );
Index: trunk/extensions/OggHandler/OggHandler.i18n.php
@@ -41,6 +41,7 @@
4242 'ogg-player-totem' => 'Totem', # only translate this message to other languages if you have to change it
4343 'ogg-player-kmplayer' => 'KMPlayer', # only translate this message to other languages if you have to change it
4444 'ogg-player-kaffeine' => 'Kaffeine', # only translate this message to other languages if you have to change it
 45+ 'ogg-player-mplayerplug-in' => 'mplayerplug-in', # only translate this message to other languages if you have to change it
4546 'ogg-player-thumbnail' => 'Still image only',
4647 'ogg-player-soundthumb' => 'No player',
4748 'ogg-player-selected' => '(selected)',

Follow-up revisions

RevisionCommit summaryAuthorDate
r38716Update per r38714raymond14:37, 6 August 2008
r62223* In preparation for deployment, revert the bulk of Michael's unreviewed work...tstarling05:51, 10 February 2010

Status & tagging log