r38614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38613‎ | r38614 | r38615 >
Date:06:01, 5 August 2008
Author:raymond
Status:old
Tags:
Comment:
Reapply part of r38587:
* 'skinpreview' renamed to 'skin-preview': brackets outside of the hyperlink now. Betawiki has done the rename job for all languages already.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -58,9 +58,6 @@
5959 'underline-never',
6060 'underline-default',
6161 ),
62 - 'skinpreview' => array(
63 - 'skinpreview',
64 - ),
6562 'dates' => array(
6663 'sunday',
6764 'monday',
@@ -752,6 +749,7 @@
753750 'qbsettings-floatingright',
754751 'changepassword',
755752 'skin',
 753+ 'skinpreview',
756754 'math',
757755 'dateformat',
758756 'datedefault',
@@ -2624,7 +2622,6 @@
26252623 XHTML id names.",
26262624 'toggles' => 'User preference toggles',
26272625 'underline' => '',
2628 - 'skinpreview' => '',
26292626 'dates' => 'Dates',
26302627 'categorypages' => 'Categories related messages',
26312628 'mainpage' => '',
Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -816,7 +816,7 @@
817817 #
818818 $wgOut->addHTML( "<fieldset>\n<legend>\n" . wfMsg('skin') . "</legend>\n" );
819819 $mptitle = Title::newMainPage();
820 - $previewtext = wfMsg('skinpreview');
 820+ $previewtext = wfMsg('skin-preview');
821821 # Only show members of Skin::getSkinNames() rather than
822822 # $skinNames (skins is all skin names from Language.php)
823823 $validSkinNames = Skin::getSkinNames();
@@ -835,7 +835,7 @@
836836 $checked = $skinkey == $this->mSkin ? ' checked="checked"' : '';
837837
838838 $mplink = htmlspecialchars($mptitle->getLocalURL("useskin=$skinkey"));
839 - $previewlink = "<a target='_blank' href=\"$mplink\">$previewtext</a>";
 839+ $previewlink = "(<a target='_blank' href=\"$mplink\">$previewtext</a>)";
840840 if( $skinkey == $wgDefaultSkin )
841841 $sn .= ' (' . wfMsg( 'default' ) . ')';
842842 $wgOut->addHTML( "<input type='radio' name='wpSkin' id=\"wpSkin$skinkey\" value=\"$skinkey\"$checked /> <label for=\"wpSkin$skinkey\">{$sn}</label> $previewlink<br />\n" );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -537,8 +537,6 @@
538538 'underline-never' => 'Never',
539539 'underline-default' => 'Browser default',
540540
541 -'skinpreview' => '(Preview)',
542 -
543541 # Dates
544542 'sunday' => 'Sunday',
545543 'monday' => 'Monday',
@@ -1403,6 +1401,7 @@
14041402 'qbsettings-floatingright' => 'Floating right',
14051403 'changepassword' => 'Change password',
14061404 'skin' => 'Skin',
 1405+'skin-preview' => 'Preview',
14071406 'math' => 'Math',
14081407 'dateformat' => 'Date format',
14091408 'datedefault' => 'No preference',

Follow-up revisions

RevisionCommit summaryAuthorDate
r38645Localisation updates. Processed consequences of r36808, 38610, r38614, r38615...siebrand17:17, 5 August 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38587* (bug 2314) Add links to users custom CSS and JS into Special:Preferences...raymond18:44, 4 August 2008

Status & tagging log