r38525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r38524‎ | r38525 | r38526 >
Date:03:00, 4 August 2008
Author:brion
Status:old
Tags:
Comment:
Change test case added in r38400
We shouldn't append a wiki link fragment onto a redlink; the edit UI is different from a page view, so appending a page-content fragment will at best do nothing and a worst conflict with the UI and scroll us down unexpectedly.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -1327,7 +1327,7 @@
13281328 !! input
13291329 [[Zigzagzogzagzig#zug]]
13301330 !! result
1331 -<p><a href="https://www.mediawiki.org/index.php?title=Zigzagzogzagzig&amp;action=edit&amp;redlink=1#zug" class="new" title="Zigzagzogzagzig (not yet written)">Zigzagzogzagzig#zug</a>
 1331+<p><a href="https://www.mediawiki.org/index.php?title=Zigzagzogzagzig&amp;action=edit&amp;redlink=1" class="new" title="Zigzagzogzagzig (not yet written)">Zigzagzogzagzig#zug</a>
13321332 </p>
13331333 !! end
13341334

Follow-up revisions

RevisionCommit summaryAuthorDate
r38534Followup to r38525 (tweaks from r38400) -- don't put fragments on redlinks; t...brion05:15, 4 August 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38400Fix the regression Brion noticed (not caused by me!) with special page links ...simetrical22:44, 1 August 2008

Status & tagging log