r38122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38121‎ | r38122 | r38123 >
Date:05:44, 28 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r38068 "SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions, such as spamRegex, to interfere with page moving"

This passes a MovePageForm, which seems unwise. It won't apply to the edit API, and generally seems like a weak interface -- an internal UI object is passed instead of specific information, leaving it unstable to future changes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1131,9 +1131,6 @@
11321132 $oldTitle: old title (object)
11331133 $newTitle: new title (object)
11341134
1135 -'SpecialMovepageBeforeMove': Called before moving a page
1136 -&$movePage: MovePageForm object
1137 -
11381135 'SpecialPageExecuteAfterPage': called after executing a special page
11391136 Warning: Not all the special pages call this hook
11401137 $specialPage: SpecialPage object
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -264,10 +264,6 @@
265265 return;
266266 }
267267
268 - if( ! wfRunHooks( 'SpecialMovepageBeforeMove', array(&$this) ) ) {
269 - return;
270 - }
271 -
272268 $ot = $this->oldTitle;
273269 $nt = $this->newTitle;
274270
Index: trunk/phase3/RELEASE-NOTES
@@ -28,8 +28,6 @@
2929
3030 * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
3131 search engine indexing on a per-article basis.
32 -* Added SpecialMovepageBeforeMove hook to allow extensions to interfere with
33 - page moves (useful for blacklist-type extensions, for example)
3432
3533 === Bug fixes in 1.14 ===
3634

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38068SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions, such ...ashley21:38, 26 July 2008

Status & tagging log