r38121 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38120‎ | r38121 | r38122 >
Date:05:31, 28 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r38040 "new hook, ConfirmEmailComplete"

This hook is incomplete and won't work as advertised. Will fail to run when the email address is confirmed through other means, such as a password reset; also there's no corresponding hook for when the mail gets *un*confirmed, so would lead to inconsistent state.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/specials/SpecialConfirmemail.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -502,9 +502,6 @@
503503 $unpatrolled: Whether or not we are showing unpatrolled changes.
504504 $watched: Whether or not the change is watched by the user.
505505
506 -'ConfirmEmailComplete': Called after a user's email has been confirmed successfully
507 -&$user: user (object) whose email is being confirmed
508 -
509506 'ContribsPager::getQueryInfo': Before the contributions query is about to run
510507 &$pager: Pager object for contributions
511508 &queryInfo: The query for the contribs Pager
Index: trunk/phase3/includes/specials/SpecialConfirmemail.php
@@ -92,7 +92,6 @@
9393 $title = SpecialPage::getTitleFor( 'Userlogin' );
9494 $wgOut->returnToMain( true, $title );
9595 }
96 - wfRunHooks( 'ConfirmEmailComplete', array( &$user ) );
9796 } else {
9897 $wgOut->addWikiMsg( 'confirmemail_invalid' );
9998 }
Index: trunk/phase3/RELEASE-NOTES
@@ -28,8 +28,6 @@
2929
3030 * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
3131 search engine indexing on a per-article basis.
32 -* Added ConfirmEmailComplete hook to allow extensions to perform actions
33 - depending on if the user's email is confirmed or not
3432 * Added SpecialMovepageBeforeMove hook to allow extensions to interfere with
3533 page moves (useful for blacklist-type extensions, for example)
3634

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38040new hook, ConfirmEmailCompleteashley18:11, 25 July 2008

Status & tagging log