r37933 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37932‎ | r37933 | r37934 >
Date:04:02, 23 July 2008
Author:sql
Status:old
Tags:
Comment:
Put requests inside double quotes, as OverlordQ pointed out to me a few seconds after the last commit, so that it is easier to distinguish exactly
which username the offending one is. Also moved a word from antispoof-name-conflict into the numbered ones, so that it can vary in plurality based
on the number of conflicts
Modified paths:
  • /trunk/extensions/AntiSpoof/AntiSpoof.i18n.php (modified) (history)
  • /trunk/extensions/AntiSpoof/AntiSpoof.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AntiSpoof/AntiSpoof.i18n.php
@@ -9,12 +9,13 @@
1010
1111 $messages['en'] = array(
1212 'antispoof-desc' => 'Blocks the creation of accounts with mixed-script, confusing and similar usernames',
13 - 'antispoof-name-conflict' => 'The name "$1" is too similar to existing accounts: "$2".
 13+ 'antispoof-name-conflict' => 'The name "$1" is too similar to existing $2.
1414 Please choose another name.',
15 - 'antispoof-name-conflict2' => '$1 $2',
16 - 'antispoof-name-conflict3' => '$1 $2 $3',
17 - 'antispoof-name-conflict4' => '$1 $2 $3 $4',
18 - 'antispoof-name-conflict5' => '$1 $2 $3 $4 $5',
 15+ 'antispoof-name-conflict1' => 'account: "$1"',
 16+ 'antispoof-name-conflict2' => 'accounts: "$1", "$2"',
 17+ 'antispoof-name-conflict3' => 'accounts: "$1", "$2", "$3"',
 18+ 'antispoof-name-conflict4' => 'accounts: "$1", "$2", "$3", "$4"',
 19+ 'antispoof-name-conflict5' => 'accounts: "$1", "$2", "$3", "$4", "$5"',
1920 'antispoof-name-illegal' => 'The name "$1" is not allowed to prevent confusing or spoofed usernames: $2.
2021 Please choose another name.',
2122 'antispoof-badtype' => 'Bad data type',
Index: trunk/extensions/AntiSpoof/AntiSpoof.php
@@ -90,7 +90,8 @@
9191 $numConflicts = count( $conflict );
9292 switch ( $numConflicts ) {
9393 case 1:
94 - $message = wfMsg( 'antispoof-name-conflict', $name, $conflict['0'] );
 94+ $message = wfMsg( 'antispoof-name-conflict', $name,
 95+ wfMsg( 'antispoof-name-conflict1', $conflict['0'] ) );
9596 break;
9697 case 2:
9798 $message = wfMsg( 'antispoof-name-conflict', $name,

Follow-up revisions

RevisionCommit summaryAuthorDate
r37938Revert r37932, r37933 -- this is just downright bizarre. o_O...brion08:15, 23 July 2008

Status & tagging log