r37633 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37632‎ | r37633 | r37634 >
Date:02:25, 14 July 2008
Author:ashley
Status:old
Tags:
Comment:
Let's not hardcode strings. And let's use proper Doxygen comments. ;-)
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php
@@ -441,7 +441,7 @@
442442 global $wgUserLevels;
443443 if( $wgUserLevels ){
444444 $output .= "<div id=\"points-level\">
445 - <a href=\"{$level_link->escapeFullURL()}\">{$stats_data["points"]} points</a>
 445+ <a href=\"{$level_link->escapeFullURL()}\">{$stats_data["points"]}".wfMsg('user-profile-points')."</a>
446446 </div>
447447 <div id=\"honorific-level\">
448448 <a href=\"{$level_link->escapeFullURL()}\" rel=\"nofollow\">({$user_level->getLevelName()})</a>
Index: trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php
@@ -1,8 +1,8 @@
22 <?php
33 /**
4 - * Internationalisation file for UserProfile extension pages.
 4+ * Internationalisation file for UserProfile extension.
55 *
6 - * @addtogroup Extensions
 6+ * @ingroup Extensions
77 */
88
99 $messages = array();
@@ -88,6 +88,7 @@
8989 'user-profile-update-log-section' => 'changed section',
9090 'user-profile-update-profile' => 'profile',
9191 'user-profile-default-country' => 'United States',
 92+ 'user-profile-points' => ' points',
9293 'user-profile-section-personal' => 'Personal information',
9394 'user-profile-section-sportsteams' => 'Update networks',
9495 'user-profile-section-custom' => 'Custom information',
@@ -1168,6 +1169,7 @@
11691170 'user-profile-update-log-section' => 'muutti osioa',
11701171 'user-profile-update-profile' => 'profiili',
11711172 'user-profile-default-country' => 'Suomi',
 1173+ 'user-profile-points' => ' pistettä',
11721174 'user-profile-section-personal' => 'Henkilökohtaiset tiedot',
11731175 'user-profile-section-sportsteams' => 'Päivitä verkostoja',
11741176 'user-profile-section-custom' => 'Omat tiedot',

Status & tagging log