r37538 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37537‎ | r37538 | r37539 >
Date:21:53, 10 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert 37530 -- removes the control option for image moving
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Namespace.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Namespace.php
@@ -52,7 +52,8 @@
5353 * @return bool
5454 */
5555 public static function isMovable( $index ) {
56 - return !( $index < NS_MAIN || $index == NS_CATEGORY );
 56+ global $wgAllowImageMoving;
 57+ return !( $index < NS_MAIN || ($index == NS_IMAGE && !$wgAllowImageMoving) || $index == NS_CATEGORY );
5758 }
5859
5960 /**
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1550,6 +1550,9 @@
15511551 */
15521552 $wgAllowExternalImagesFrom = '';
15531553
 1554+/** Allows to move images and other media files. Experemintal, not sure if it always works */
 1555+$wgAllowImageMoving = false;
 1556+
15541557 /** Disable database-intensive features */
15551558 $wgMiserMode = false;
15561559 /** Disable all query pages if miser mode is on, not just some */
Index: trunk/phase3/RELEASE-NOTES
@@ -129,7 +129,7 @@
130130 and local one
131131 * Update documentation links in auto-generated LocalSettings.php
132132 * (bug 13584) The new hook SkinTemplateToolboxEnd was added.
133 -* (bug 709) Cannot rename/move images and other media files
 133+* (bug 709) Cannot rename/move images and other media files [EXPERIMENTAL]
134134 * Custom rollback summaries now accept the same arguments as the default message
135135 * (bug 12542) Added hooks for expansion of Special:Listusers
136136 * Drop-down AJAX search suggestions (turn on $wgEnableMWSuggest)

Status & tagging log