r37264 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r37263‎ | r37264 | r37265 >
Date:16:56, 7 July 2008
Author:demon
Status:old
Tags:
Comment:
Remove unused (and seemingly useless) param from confirmDelete().
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2093,7 +2093,7 @@
20942094 }
20952095 }
20962096
2097 - return $this->confirmDelete( '', $reason );
 2097+ return $this->confirmDelete( $reason );
20982098 }
20992099
21002100 /**
@@ -2168,10 +2168,9 @@
21692169
21702170 /**
21712171 * Output deletion confirmation dialog
2172 - * @param $par string FIXME: do we need this parameter? One Call from Article::delete with '' only.
21732172 * @param $reason string Prefilled reason
21742173 */
2175 - function confirmDelete( $par, $reason ) {
 2174+ function confirmDelete( $reason ) {
21762175 global $wgOut, $wgUser, $wgContLang;
21772176 $align = $wgContLang->isRtl() ? 'left' : 'right';
21782177
@@ -2189,7 +2188,7 @@
21902189 $suppress = '';
21912190 }
21922191
2193 - $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->mTitle->getLocalURL( 'action=delete' . $par ), 'id' => 'deleteconfirm' ) ) .
 2192+ $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->mTitle->getLocalURL( 'action=delete' ), 'id' => 'deleteconfirm' ) ) .
21942193 Xml::openElement( 'fieldset', array( 'id' => 'mw-delete-table' ) ) .
21952194 Xml::tags( 'legend', null, wfMsgExt( 'delete-legend', array( 'parsemag', 'escapenoentities' ) ) ) .
21962195 Xml::openElement( 'table' ) .

Follow-up revisions

RevisionCommit summaryAuthorDate
r37265More cleanup from r37264demon16:56, 7 July 2008

Status & tagging log