r36876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r36875‎ | r36876 | r36877 >
Date:02:31, 2 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r36523 -- removal of the fieldset made Recentchanges/Recentchangeslinked very ugly!
Options were in a table, which ended up showing white background without the fieldset (some sites use a light blue background for specials).
Generally everything just ran together, making it hard to visually distinguish the bits of the page.
It's looking much better with the set restored...
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
——@@ -123,6 +123,7 @@
124124 $batch->execute();
125125 $this->webOutput( $rows, $opts );
126126 }
 127+
127128 }
128129
129130 /**
——@@ -407,6 +408,7 @@
408409
409410 $panel = array();
410411 $panel[] = $this->optionsPanel( $defaults, $nondefaults );
 412+ $panel[] = '<hr />';
411413
412414 $extraOpts = $this->getExtraOptions( $opts );
413415
——@@ -434,7 +436,9 @@
435437 $panel[] = $form;
436438 $panelString = implode( "\n", $panel );
437439
438 - $wgOut->addHTML( '<div class="rcoptions">' . $panelString . '</div>' );
 440+ $wgOut->addHTML(
 441+ Xml::fieldset( wfMsg( 'recentchanges' ), $panelString, array( 'class' => 'rcoptions' ) )
 442+ );
439443
440444 $this->setBottomText( $wgOut, $opts );
441445 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r36943Fix for r36876: use the page name instead of 'recentchanges' to show "Related...ialex19:52, 2 July 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36523Removing the recent changes fieldset, per complaints from some users.rotem10:51, 21 June 2008

Status & tagging log